Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable publishing of stable labels #62

Closed
ptr727 opened this issue Nov 17, 2022 · 4 comments
Closed

Disable publishing of stable labels #62

ptr727 opened this issue Nov 17, 2022 · 4 comments
Labels
external External dependency

Comments

@ptr727
Copy link
Owner

ptr727 commented Nov 17, 2022

Publishing of stable labels to docker images are temporarily disabled.

The problem scenario:

  • The stable tag was added to 4.2 versioned releases in docker.
  • Nx releases JSON API data promoted 5.0 to "released" status. (per my interpretation of the data)
  • The stable tag was added to the 5.0 versioned releases in docker.
  • Nx releases JSON API data reverted the change, and again made 4.2 the "released" version.
  • In-place upgrading from 4.2 to 5.0 is a Nx supported scenario, downgrading from 5.0 to 4.2 is not a Nx supported scenario.
  • Any system using the stable tag would have automatically upgraded their 4.2 build to the 5.0 build.
  • As it is not possible to in-place downgrade builds, the stable tag cannot be re-applied to the 4.2 builds.

Publishing of stable labels will resume when 5.0 is again promoted to a "released" status.

P.s. Refer to best practices and use case studies for "fix forward vs. roll back".

@ptr727
Copy link
Owner Author

ptr727 commented May 13, 2023

Stable versions are still flip-flopping between 4.2 and 5.0.

Updated the CreateMatrix tool to conditionally update labels:

  • If the versions are 5.0 or later, then stable and latest will be updated.
  • If the versions are 5.1 or later, then beta and rc will be updated.
  • If the versions are later that than the last saved update, then versions will be updated.

Using this method no label should ever regress to an older version.

@ptr727
Copy link
Owner Author

ptr727 commented Jun 3, 2023

Similar problem observed on change pushed to DWSpectrum RC build on 3 June 2023.
RC 5.1.0.36830 reverted to 5.1.0.36751, you can never go back!

Before 5.1.0.36830:

    {
      "Product": "DWSpectrum",
      "Versions": [
        {
          "Version": "5.1.0.36830",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/36830/dwspectrum-server_update-5.1.0.36830-linux_x64-rc.zip",
          "Labels": [
            "RC"
          ]
        },
        {
          "Version": "5.0.0.36871",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/36871/dwspectrum-server_update-5.0.0.36871-linux_x64.zip",
          "Labels": [
            "Latest"
          ]
        },
        {
          "Version": "4.2.0.32842",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/32842/dwspectrum-server_update-4.2.0.32842-linux64.zip",
          "Labels": []
        }
      ]
    }

After 5.1.0.36751

    {
      "Product": "DWSpectrum",
      "Versions": [
        {
          "Version": "5.1.0.36751",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/36751/dwspectrum-server_update-5.1.0.36751-linux_x64-rc.zip",
          "Labels": [
            "RC"
          ]
        },
        {
          "Version": "5.0.0.36871",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/36871/dwspectrum-server_update-5.0.0.36871-linux_x64.zip",
          "Labels": [
            "Latest"
          ]
        },
        {
          "Version": "4.2.0.32842",
          "Uri": "https://updates.networkoptix.com/digitalwatchdog/32842/dwspectrum-server_update-4.2.0.32842-linux64.zip",
          "Labels": []
        }
      ]
    }

@ptr727
Copy link
Owner Author

ptr727 commented Jul 2, 2023

And around 1 July 2023 5.1 was promoted to release, then two days later reverted to RC then a day later back to release again, arggg.

@ptr727
Copy link
Owner Author

ptr727 commented Jul 31, 2023

Build tooling will now not let tagged versions regress.

@ptr727 ptr727 closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external External dependency
Projects
None yet
Development

No branches or pull requests

1 participant