From d4ccbed5b05352278f7d7b715492d680d081ef7e Mon Sep 17 00:00:00 2001 From: Paul Johnston Date: Thu, 19 Jan 2017 04:05:07 -0700 Subject: [PATCH] Disable sha256 in WORKSPACE until less flaky Also update travis script. --- .travis.yml | 4 +++- README.md | 4 ++++ WORKSPACE | 10 +++++----- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index f7a0b30..b71a42a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,7 +8,9 @@ os: - osx env: - - V=HEAD + - V=0.4.3 + - V=0.4.2 + - V=0.4.1 - V=0.4.0 - V=0.3.2 - V=0.3.1 diff --git a/README.md b/README.md index a2a3e18..fd89246 100644 --- a/README.md +++ b/README.md @@ -80,6 +80,10 @@ you can determine this). By setting a `sha256`, you can guard against the code changing, but you are not guarding against a malicious attacker sneaking in bogus code in the first place. +> Note: the `WORKSPACE` for `rules_node` itself is not yet using the +> sha256 option as there seems to be remaining non-determinism that +> renders it flaky. + #### What gets removed before determining the sha256? In order to make npm deterministic it is necessary to: diff --git a/WORKSPACE b/WORKSPACE index 86b3c12..badd93e 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -17,7 +17,7 @@ npm_repository( "react": "15.3.2", "react-dom": "15.3.2", }, - sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0", + #sha256 = "fa7f0306841e8f03de78bd4b80f0da525238cf95cb360d7072013ca5fe7215e0", ) npm_repository( @@ -25,7 +25,7 @@ npm_repository( deps = { "mocha": "3.1.0", }, - sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8", + #sha256 = "9b48987065bb42003bab81b4538afa9ac194d217d8e2e770a5cba782249f7dc8", ) npm_repository( @@ -33,7 +33,7 @@ npm_repository( deps = { "underscore": "1.8.3", }, - sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8", + #sha256 = "7c413345ad4f97024258e5d9fda40e26be0f2c2b73987d13f03352b5c489b1a8", ) npm_repository( @@ -41,7 +41,7 @@ npm_repository( deps = { "bower": "1.7.9", }, - sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f", + #sha256 = "7f85a05c00a86b0f9cfd8d58ad61d0447bd9235d13a743ede87af1ca5509403f", ) bower_repository( @@ -49,5 +49,5 @@ bower_repository( deps = { "react": "15.3.2", }, - sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845", + #sha256 = "9779fcd247213b898d53473d4cc884f8b2d64b7d8021f56dd54a6dcd5f1bf845", )