From 5005436a473a1c4e9bfcd623a2f4d1bd1fa9061b Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Tue, 12 Dec 2023 23:06:29 -0500 Subject: [PATCH 1/2] src: Fix usage/help text for -b/-t flags for ppm install These flags do not *actually* take commit SHAs as arguments, only branch or tag names. The flags are aliases of one-another and work the exact same -- *either* flag can take a branch name *or* tag name. No SHAs. --- src/install.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/install.js b/src/install.js index 2cf68a43..988134bc 100644 --- a/src/install.js +++ b/src/install.js @@ -39,8 +39,8 @@ class Install extends Command { Usage: ppm install [...] ppm install @ - ppm install [-b ] - ppm install / [-b ] + ppm install [-b ] + ppm install / [-b ] ppm install --packages-file my-packages.txt ppm i (with any of the previous argument usage) From ad9d31ab5cc87c8de5b4eec10ba31d380df961c3 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Wed, 13 Dec 2023 01:35:38 -0500 Subject: [PATCH 2/2] src: Update error text for -b/-t flags in install.js These flags don't accept commit hashes, only tag or branch names. --- src/install.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/install.js b/src/install.js index 988134bc..b3a7352a 100644 --- a/src/install.js +++ b/src/install.js @@ -565,7 +565,7 @@ Run ppm -v after installing Git to see what version has been detected.\ const repo = Git.open(cloneDir); data.sha = version; const checked = repo.checkoutRef(`refs/tags/${version}`, false) || repo.checkoutReference(version, false); - if (!checked) { throw `Can't find the branch, tag, or commit referenced by ${version}`; } + if (!checked) { throw `Can't find the branch or tag referenced by ${version}`; } } else { const sha = this.getRepositoryHeadSha(cloneDir); data.sha = sha;