Fix asset rebuilds & dependencies #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rebuild the binary if any go source files change (use a wildcard here rather than limiting to resource.go). - Rebuild the binary if upstream changes in any way.
When we restore the make progress as an asset it had the timestamps of when the files were created in the original job, as expected. However, the source files had been freshly checked out. Therefore, any file that has already been built in a previous job and restored in a subsequent job was older than the freshly checked out files and was rebuilt, causing longer runtimes. - Any job that depends on the `prerequisites` job (and restores its artifacts) should touch the `provider` and `schema` targets. - Any job that depends on the `build_sdk` job matrix should touch the `provider`, `schema` and `build_[language]` targets.
blampe
approved these changes
Nov 26, 2024
Comment on lines
-51
to
-54
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: prerequisites.make | ||
| path: .make |
There was a problem hiding this comment.
Fewer dependent GitHub actions is always a good thing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1151
Fixes #1157
Fix tfgen makefile dependencies
Use make --touch for restoring progress
When we restore the make progress as an asset it had the timestamps of when the files were created in the original job, as expected. However, the source files had been freshly checked out. Therefore, any file that has already been built in a previous job and restored in a subsequent job was older than the freshly checked out files and was rebuilt, causing longer runtimes.
prerequisitesjob (and restores its artifacts) should touch theproviderandschematargets.build_sdkjob matrix should touch theprovider,schemaandbuild_[language]targets.