Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset rebuilds & dependencies #1157

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Fix asset rebuilds & dependencies #1157

merged 2 commits into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. Fix tfgen makefile deps 

    - Rebuild the binary if any go source files change (use a wildcard here rather than limiting to resource.go).
- Rebuild the binary if upstream changes in any way.
    @danielrbradley
    danielrbradley committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    4c68550 View commit details
    Browse the repository at this point in the history

  2. Use make --touch for restoring progress 

    When we restore the make progress as an asset it had the timestamps of when the files were created in the original job, as expected. However, the source files had been freshly checked out. Therefore, any file that has already been built in a previous job and restored in a subsequent job was older than the freshly checked out files and was rebuilt, causing longer runtimes.

- Any job that depends on the `prerequisites` job (and restores its artifacts) should touch the `provider` and `schema` targets.
- Any job that depends on the `build_sdk` job matrix should touch the `provider`, `schema` and `build_[language]` targets.
    @danielrbradley
    danielrbradley committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    77d6f85 View commit details
    Browse the repository at this point in the history