Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error with manually installing pre-downloaded deken package #301

Open
umlaeute opened this issue Jun 26, 2024 · 0 comments
Open

error with manually installing pre-downloaded deken package #301

umlaeute opened this issue Jun 26, 2024 · 0 comments

Comments

@umlaeute
Copy link
Contributor

yesterday i downloaded a package Gem(Darwin-amd64-32)(Darwin-amd64-64)(Darwin-arm64-32)(Darwin-arm64-64).dek
today i downloaded an updated version of the same file, that ended up as Gem(Darwin-amd64-32)(Darwin-amd64-64)(Darwin-arm64-32)(Darwin-arm64-64)-2.dek on my disk.

Trying to install the latter resulted in an error popup:

deken_optionstring

now i guess the problem is, that the -2 suffix (before the extension), renders the filename an invalid deken filename, so the regex fails and consequently there's no optionstring variable:

deken/deken-plugin.tcl

Lines 731 to 732 in ca7e26e

regexp {^([^\[\]\(\)]+)((\[[^\[\]\(\)]+\])*)((\([^\[\]\(\)]+\))*)\.dek$} $filename _ pkgname optionstring _ archstring
foreach {o _} [lreplace [split $optionstring {[]}] 0 0] {

i think, this could be handled better: either by relaxing the parsing constraints (and allowing a -2 infix, at least for local files), or by providing a better error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant