Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace paperclip workaround with a better fix #207

Closed
pwnall opened this issue Aug 23, 2016 · 1 comment
Closed

Replace paperclip workaround with a better fix #207

pwnall opened this issue Aug 23, 2016 · 1 comment

Comments

@pwnall
Copy link
Owner

pwnall commented Aug 23, 2016

The workaround was introduced in 354d76d in response to thoughtbot/paperclip#2270

The change introduced there was breaking tests: https://travis-ci.org/pwnall/igor/builds/154374216

A better solution would involve having Paperclip pass the uploaded file's MIME type as a hint into the file content detector's detect method. We could then implement our own detector.
@pwnall
Copy link
Owner Author

pwnall commented Nov 13, 2016

Paperclip removed in e11611b

@pwnall pwnall closed this as completed Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pwnall