avoid placing the flyout in a hidden sidebar #1133
Conversation
Closes cupy#7374. Let's stick with v0.11.0 until pydata/pydata-sphinx-theme#1133 got merged. discussion: pydata/pydata-sphinx-theme#1161
There was a problem hiding this comment.
@12rambau on the PR build it looked weird to me that the RTD switcher was floating in the bottom right and our theme's version switcher was in the topbar. At first I thought that anyone who requested the theme's version switcher wouldn't want the (redundant) RTD switcher too? But then I realized that the redundant switcher has been there all along, hidden at the bottom of the sidebar below the ethical ads.
So I pushed a commit here b18046d to suppress the RTD flyout if the theme's version switcher is found on the page, but if you think that's a bad idea feel free to revert. I've also pushed a docs update describing our RTD version flyout integration (if you revert you'll need to delete one line of the docs update too).
Otherwise this LGTM, if you agree please take out of draft mode and we can merge.
Currently that is indeed a bad idea as the RDT witcher also include language switch that we still don't support. If you could reverse it that would be great and I'll update this PR to see if it works as expected. |
|
ok I reverted the changes (which weren't working anyway) that try to suppress the RTD switcher. Looking at the PR build though, things are still not working right here; the RTD switcher seems to be always bottom-right even on pages that have a sidebar, e.g. https://pydata-sphinx-theme--1133.org.readthedocs.build/en/1133/user_guide/index.html |
|
It's not working as expected and creates to many caveheat; I think I'll focus on #705 instead which should solve every problems at once. |
closes #1092