Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

value::Serializer should set is_human_readable to false #136

Closed
kostko opened this issue Jul 8, 2019 · 0 comments · Fixed by #137
Closed

value::Serializer should set is_human_readable to false #136

kostko opened this issue Jul 8, 2019 · 0 comments · Fixed by #137

Comments

@kostko
Copy link
Contributor

kostko commented Jul 8, 2019

Currently value::Serializer::is_human_readable returns true (by default as it is not overriden), leading to incorrect serialization when compared to using the regular serde_cbor serializer which correctly returns false.

This causes problems as serializing via value::Value is the only way (in 0.10) to achieve canonical serialization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant