Drop python 3.8 support #3143
Merged
Drop python 3.8 support #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we first release 2.5.2 then drop the support for 3.8 ? |
ankith26
force-pushed
the
ankith26-drop-py38
branch
from
166c88d to
235b346
Compare
damusss
added
Code quality/robustness
|
I agree with bilhox, no rush to drop it. |
Yeah definitely. I just wanted to put this PR out there. We can wait a couple of months on this. |
ankith26
force-pushed
the
ankith26-drop-py38
branch
2 times, most recently
from
a93bc11 to
b3609cc
Compare
Starbuck5
reviewed
Nov 2, 2024
Starbuck5
reviewed
Nov 2, 2024
ankith26
force-pushed
the
ankith26-drop-py38
branch
from
b3609cc to
ff42cdf
Compare
zoldalma999
reviewed
Nov 16, 2024
ankith26
force-pushed
the
ankith26-drop-py38
branch
from
ff42cdf to
46da882
Compare
ankith26
force-pushed
the
ankith26-drop-py38
branch
from
46da882 to
81fc491
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is EOL. We can now consider dropping it.
The biggest advantage of doing this is nicer type stubs.