Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traditional Chinese Readme #3162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hisa10
Copy link
Contributor

@hisa10 hisa10 commented Oct 10, 2024

Related to #3113.
Based on contribution from @noahcse, I fixed outdated "dependencies" section and added "How to contribute" section.

@hisa10 hisa10 requested a review from a team as a code owner October 10, 2024 13:15
@bilhox
Copy link
Contributor

bilhox commented Oct 10, 2024

Hi,
Why is there 2 PRs for the same additional ? You might want to ask @noahcse if he still wants to work on the PR or not before that.

@bilhox
Copy link
Contributor

bilhox commented Oct 13, 2024

Hi @hisa10 ,

As the work was also started by someone else 3 weeks ago, after a bit of discussion with other members, I request a co-authored commit (including the person who started the work 3 weeks ago). Except that, it's fine.

@bilhox bilhox added this to the 2.5.3 milestone Oct 13, 2024
@yunline yunline added the docs label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants