Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port time, surflock and constants to SDL3 #3206

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 2, 2024

I clubbed all these updates in one PR because these modules were mostly trivial to port.

import pygame works now! (although with warnings, and in a very unusable state)

@ankith26 ankith26 requested a review from a team as a code owner November 2, 2024 08:48
src_c/time.c Outdated Show resolved Hide resolved
@Starbuck5 Starbuck5 added the sdl3 label Nov 2, 2024
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Starbuck5 Starbuck5 added the time pygame.time label Nov 3, 2024
Copy link
Contributor

@gresm gresm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @ankith26 Left a comment on one part, but it's not anything blocking this PR.

src_c/surflock.c Outdated Show resolved Hide resolved
@ankith26 ankith26 added this to the 2.5.3 milestone Nov 5, 2024
@ankith26 ankith26 merged commit 71e5c18 into main Nov 5, 2024
25 checks passed
@ankith26 ankith26 deleted the ankith26-more-sdl3 branch November 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdl3 time pygame.time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants