Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build dependencies and use dev.py on msys2/multiarch CI #3211

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 3, 2024

Separated out from #3128 for independent review.

Most of the bumps are minor bumps, but there's also a major version bump for sphinx. From what I can tell nothing broke here, but more eyes on this would definitely be helpful.

@ankith26 ankith26 requested a review from a team as a code owner November 3, 2024 09:40
@ankith26 ankith26 force-pushed the ankith26-bump-build-deps branch from c8e4019 to d5f64d5 Compare November 3, 2024 12:22
@ankith26 ankith26 changed the title Bump build dependencies Bump build dependencies and use dev.py on msys2/multiarch CI Nov 3, 2024
@yunline yunline added the CI Issue with the Continuous Integration (CI), the actions/bots that test things label Nov 4, 2024
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while building the docs with sphinx 8.1.3, got the following message:

checking consistency... \docs\reST\tutorials\chimp.py.rst: document is referenced in multiple toctrees: ['tutorials/en/chimp-explanation', 'tutorials/es/ChimpanceLineaporLinea'], selecting: tutorials/es/ChimpanceLineaporLinea <- tutorials/chimp.py
\docs\reST\tutorials\en\tom-games2.rst: document is referenced in multiple toctrees: ['index', 'tutorials/en/make-games'], selecting: tutorials/en/make-games <- tutorials/en/tom-games2
\docs\reST\tutorials\en\tom-games3.rst: document is referenced in multiple toctrees: ['index', 'tutorials/en/make-games'], selecting: tutorials/en/make-games <- tutorials/en/tom-games3
\docs\reST\tutorials\en\tom-games4.rst: document is referenced in multiple toctrees: ['index', 'tutorials/en/make-games'], selecting: tutorials/en/make-games <- tutorials/en/tom-games4
\docs\reST\tutorials\en\tom-games5.rst: document is referenced in multiple toctrees: ['index', 'tutorials/en/make-games'], selecting: tutorials/en/make-games <- tutorials/en/tom-games5
\docs\reST\tutorials\en\tom-games6.rst: document is referenced in multiple toctrees: ['index', 'tutorials/en/make-games'], selecting: tutorials/en/make-games <- tutorials/en/tom-games6

This does not block the PR necessarily, but should be fixed at some point.

Otherwise looks good to me, I did not see any issues with the generated docs.

@ankith26 ankith26 force-pushed the ankith26-bump-build-deps branch from d5f64d5 to a6e2647 Compare November 21, 2024 06:28
@ankith26
Copy link
Member Author

Just force pushed with a rebase on main, and while I was at it I did a couple of other dependency updates that I had missed

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM 👍

@MyreMylar MyreMylar merged commit 746197d into main Dec 1, 2024
24 checks passed
@ankith26 ankith26 added this to the 2.5.3 milestone Dec 9, 2024
@ankith26 ankith26 deleted the ankith26-bump-build-deps branch December 9, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants