Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of imp modules should be removed #829

Closed
jonringer opened this issue Nov 26, 2021 · 2 comments
Closed

Use of imp modules should be removed #829

jonringer opened this issue Nov 26, 2021 · 2 comments
Assignees

Comments

@jonringer
Copy link

The imp module has been deprecated since python 3.4, and now emits warnings when used in python 3.9.6+.

The logic should be replaced with importlib.

Now if this package, or any downstream dependency uses this, pytest deprecation warnings need to be silenced or else it fails a test suite.

jonringer added a commit to NixOS/nixpkgs that referenced this issue Nov 26, 2021
Deprecation warnings kill the test suite
pyinvoke/invoke#829
jonringer added a commit to NixOS/nixpkgs that referenced this issue Nov 30, 2021
Deprecation warnings kill the test suite
pyinvoke/invoke#829
jonringer added a commit to NixOS/nixpkgs that referenced this issue Dec 1, 2021
Deprecation warnings kill the test suite
pyinvoke/invoke#829
@neozenith neozenith self-assigned this Mar 26, 2022
@robbieaverill
Copy link

Duplicate of #675. There's some context in there for how to disable this deprecation warning in pytest runs.

@bitprophet
Copy link
Member

#919 merged and released in Invoke 2.1.0 today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants