Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant migration blacklisting if possible #289

Open
carlio opened this issue Aug 28, 2020 · 0 comments
Open

Remove redundant migration blacklisting if possible #289

carlio opened this issue Aug 28, 2020 · 0 comments
Labels

Comments

@carlio
Copy link
Member

carlio commented Aug 28, 2020

Adding to the list of 'do not check these paths' for migrations is done in two places:

https://github.com/PyCQA/pylint-django/blob/master/pylint_django/checkers/migrations.py#L159
https://github.com/PyCQA/pylint-django/blob/master/pylint_django/plugin.py#L21

This should be removed unless there is some reason that it is repeated.

@carlio carlio added the todo label Aug 28, 2020
carlio added a commit that referenced this issue Aug 28, 2020
…the plugin is loaded, migrations are added to the blacklist. The migrations checker then removes them from the blacklist, and since it edits linter.config, it is not only done for the migrations checker but globally. Therefore the plugin should simply not manage the blacklist for migrations (also avoiding overriding any user-specified behaviour in their .pylintrc)
carlio added a commit that referenced this issue Aug 28, 2020
carlio added a commit that referenced this issue Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant