Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON output contains html-escaped characters (intentional?) #2769

Closed
jgsogo opened this issue Feb 27, 2019 · 3 comments · Fixed by #3467
Closed

JSON output contains html-escaped characters (intentional?) #2769

jgsogo opened this issue Feb 27, 2019 · 3 comments · Fixed by #3467

Comments

@jgsogo
Copy link

jgsogo commented Feb 27, 2019

Hi! We've just found in our CI that the JSON output has changed in v2.3.0, it is escaping some characters.

Is it intentional, or should it be reverted to previous behavior?

Thanks!

Steps to reproduce

Run pylint on any file with an unused variable

Current behavior

[
    {
        "type": "warning",
        "module": "conanfile",
        "obj": "TestConan.build",
        "line": 9,
        "column": 15,
        "path": "conanfile.py",
        "symbol": "unused-variable",
        "message": "Unused variable 'v'",
        "message-id": "W0612"
    }
]

Expected behavior

[
    {
        "type": "warning",
        "module": "conanfile",
        "obj": "TestConan.build",
        "line": 9,
        "column": 15,
        "path": "conanfile.py",
        "symbol": "unused-variable",
        "message": "Unused variable 'v'",
        "message-id": "W0612"
    }
]

pylint --version output

pylint 2.3.0
astroid 2.2.0
Python 3.7.2 (default, Feb 12 2019, 08:16:38)
@PCManticore
Copy link
Contributor

It's probably not intentional, thanks for reporting the issue.

@PCManticore
Copy link
Contributor

Hey @jgsogo This is fixed, will be part of pylint 2.3.1 soon. I'm doing a pass through the regressions and will release a new bug fix release after that.

@jgsogo
Copy link
Author

jgsogo commented Feb 28, 2019

Wow! Thanks for the quick response. 💯

cpitclaudel added a commit to cpitclaudel/pylint that referenced this issue Mar 31, 2020
The JSON module already escapes special characters as needed.

This was already reported in pylint-dev#2769 and partially addressed by
6b1adc6, but that commit still quotes angle
brackets ('<' and '>').
cpitclaudel added a commit to cpitclaudel/pylint that referenced this issue Mar 31, 2020
The JSON module already escapes special characters as needed.

This was already reported in pylint-dev#2769 and partially addressed by
6b1adc6, but that commit still quotes angle
brackets ('<' and '>').
PCManticore pushed a commit that referenced this issue Apr 3, 2020
The JSON module already escapes special characters as needed.

This was already reported in #2769 and partially addressed by
6b1adc6, but that commit still quotes angle
brackets ('<' and '>').
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants