Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggesting to use min()/max() #3406

Closed
EugeneZelenko opened this issue Feb 13, 2020 · 2 comments · Fixed by #4359
Closed

Suggesting to use min()/max() #3406

EugeneZelenko opened this issue Feb 13, 2020 · 2 comments · Fixed by #4359
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors Help wanted 🙏 Outside help would be appreciated, good for new contributors

Comments

@EugeneZelenko
Copy link

It'll be great to recognize code patterns that could be replaced with min() and max() functions. For example:

if value < 10: value = 10

with value = max(value, 10)
@PCManticore PCManticore added Good first issue Friendly and approachable by new contributors Enhancement ✨ Improvement to a component labels Feb 14, 2020
@Pierre-Sassoulas Pierre-Sassoulas added the Help wanted 🙏 Outside help would be appreciated, good for new contributors label Mar 2, 2021
@Qwiddle13 Qwiddle13 mentioned this issue Apr 15, 2021
Merged
4 tasks
@Qwiddle13
Copy link
Contributor

@Pierre-Sassoulas who's the right person to review the pull request?

@Pierre-Sassoulas
Copy link
Member

Well, at least a contributor with write access with the time to review and anyone with the time to review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component Good first issue Friendly and approachable by new contributors Help wanted 🙏 Outside help would be appreciated, good for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement/add checker consider using min max builtin Qwiddle13/pylint
4 participants
@PCManticore @Pierre-Sassoulas @EugeneZelenko @Qwiddle13