Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking API change in 2.5.1 #3590

Closed
gangefors opened this issue May 5, 2020 · 1 comment
Closed

Breaking API change in 2.5.1 #3590

gangefors opened this issue May 5, 2020 · 1 comment
Labels
Regression

Comments

@gangefors
Copy link

Steps to reproduce

  1. Install pylint 2.5.1 together with pytest-pylint>1.5.0
  2. Run any unit test with pytest enabling the use of the pylint plugin

Current behavior

INTERNALERROR>   File "/home/stefanga/projects/oe-fwrt/.tox/scripts/lib/python3.5/site-packages/pytest_pylint/plugin.py", line 174, in pytest_collection_finish
INTERNALERROR>     result = lint.Run(args_list, reporter=reporter, do_exit=False)
INTERNALERROR> TypeError: __init__() got an unexpected keyword argument 'do_exit'

Expected behavior

pytest-pylint successfully work with pylint 2.x

The API change was introduced in #3554 and should be reverted since it breaks the API in a patch release.
@gangefors gangefors mentioned this issue May 5, 2020
Closed
@PCManticore
Copy link
Contributor

Sorry for the hassle, feel free to submit a PR to pytest-pylint.

PCManticore added a commit that referenced this issue May 5, 2020
@PCManticore
pylint.Run accepts do_exit as a deprecated parameter
55d6c3b 
We need to allow various third party libraries that depend on `pylint` to still use
`do_exit` until they can move over to `exit`.

Close #3590
@PCManticore PCManticore mentioned this issue May 5, 2020
Merged
PCManticore added a commit that referenced this issue May 5, 2020
@PCManticore
pylint.Run accepts do_exit as a deprecated parameter
25223a9 
We need to allow various third party libraries that depend on `pylint` to still use
`do_exit` until they can move over to `exit`.

Close #3590
PCManticore added a commit that referenced this issue May 5, 2020
@PCManticore
pylint.Run accepts do_exit as a deprecated parameter
43449de 
We need to allow various third party libraries that depend on `pylint` to still use
`do_exit` until they can move over to `exit`.

Close #3590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gangefors @PCManticore