Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad-continuation recognized ijn 2.13.9 but not in 2.14 #6809

Closed
rafaellehmkuhl opened this issue Jun 2, 2022 · 2 comments
Closed

bad-continuation recognized ijn 2.13.9 but not in 2.14 #6809

rafaellehmkuhl opened this issue Jun 2, 2022 · 2 comments
Labels

Comments

@rafaellehmkuhl
Copy link

rafaellehmkuhl commented Jun 2, 2022

Question

I have a CI running with pylint and I disable the bad-continuation check in pyproject.toml:

[tool.pylint]
    [tool.pylint.master]
    enable = "all"
    disable = [
        "attribute-defined-outside-init",
        "bad-continuation", # Black takes care of that for us
        "broad-except",
        "duplicate-code",
        "import-error",
        "inconsistent-return-statements",
        "invalid-name",
        "line-too-long", # We already have this in black.
        "locally-disabled", # We know what we are doing, necessary to load plugins in runtime
        "logging-fstring-interpolation", # We want a good-to-read logging interface
        "missing-class-docstring",
        "missing-function-docstring",
        "missing-module-docstring",
        "no-member", # Some members are created in runtime, pylint fails to detect such cases
        "no-name-in-module", # Names can be generated in runtime
        "protected-access", # Necessary for internal tests
        "suppressed-message",
        "too-few-public-methods", # We know what kind of architecture we want
        "too-many-public-methods", # Wrappers will have multiple public methods
        "useless-super-delegation", # Fails to check it properly
        "wildcard-import", # Necessary to locate installed plugins
        "wrong-import-position",
        ]

    [tool.pylint.miscellaneous]
    notes = [ "FIXME" ] # TODO is removed for internal development

With pylint 2.13.9 everything was fine, but with the update to 2.14.0 I started receiving this:

************* Module /home/runner/work/BlueOS-docker/BlueOS-docker/pyproject.toml
pyproject.toml:1:0: E0012: Bad option value for --disable. Don't recognize message bad-continuation. (bad-option-value)

Documentation for future user

I couldn't find any information regarding the bad-continuation check (or changes to it) in the docs. Is this the case where it was removed some versions ago and the 2.14.0 refactor to the bad-option-value is now warning about it?

Additional context

No response

@rafaellehmkuhl rafaellehmkuhl added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Jun 2, 2022
@Pierre-Sassoulas
Copy link
Member

bad-continuation was removed from pylint in #3565 (pylint 2.6.0) , the parsing got better in 2.14.0 and we're now warning when a message is not valid in the disable option.

@Pierre-Sassoulas Pierre-Sassoulas added Question and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Jun 2, 2022
@rafaellehmkuhl
Copy link
Author

rafaellehmkuhl commented Jun 2, 2022

bad-continuation was removed from pylint in #3565 (pylint 2.6.0) , the parsing got better in 2.14.0 and we're now warning when a message is not valid in the disable option.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants