Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help-msg no longer accepts comma separate messages since v2.14.0 #7471

Closed
yilei opened this issue Sep 15, 2022 · 2 comments · Fixed by #7490
Closed

--help-msg no longer accepts comma separate messages since v2.14.0 #7471

yilei opened this issue Sep 15, 2022 · 2 comments · Fixed by #7490
Assignees
Labels
Discussion 🤔 Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Milestone

Comments

@yilei
Copy link
Contributor

yilei commented Sep 15, 2022

I'm not sure if this is intentional since I don't find it mentioned anywhere in the changelog.

In v2.13.9:

$ pylint --help-msg C0102,C0103
:disallowed-name (C0104): *Disallowed name "%s"*
  Used when the name matches bad-names or bad-names-rgxs- (unauthorized names).
  This message belongs to the basic checker.

:invalid-name (C0103): *%s name "%s" doesn't conform to %s*
  Used when the name doesn't conform to naming rules associated to its type
  (constant, variable, class...). This message belongs to the basic checker.

In v2.14.0:

$ pylint --help-msg C0102,C0103
No such message id or symbol 'C0102,C0103'.

Possibly a side effect when migrating to argparse?

I don't think this is a big deal, and not sure if there are other similar affected flags. But it might be still worth mentioning somewhere about this change.

@Pierre-Sassoulas Pierre-Sassoulas added Needs decision 🔒 Needs a decision before implemention or rejection Discussion 🤔 labels Sep 16, 2022
@Pierre-Sassoulas
Copy link
Member

There's an argument to be made that if it works for --enable or --disable then it should also work for --help-msg.

@DanielNoord
Copy link
Collaborator

I need to have a look why this no longer works. It could be that this is the result of using argparse, it tends to parse arguments just slightly different compared to optparse. But I agree, if it isn't too much hassle we should probably support this!

@DanielNoord DanielNoord added Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning and removed Needs decision 🔒 Needs a decision before implemention or rejection labels Sep 16, 2022
@DanielNoord DanielNoord self-assigned this Sep 16, 2022
@DanielNoord DanielNoord added Needs PR This issue is accepted, sufficiently specified and now needs an implementation and removed Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning labels Sep 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.3 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion 🤔 Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants