Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate / remove support for .vcg files in pyreverse #8416

Closed
DudeNr33 opened this issue Mar 9, 2023 · 4 comments · Fixed by #8426, #8521 or #9093
Closed

Deprecate / remove support for .vcg files in pyreverse #8416

DudeNr33 opened this issue Mar 9, 2023 · 4 comments · Fixed by #8426, #8521 or #9093
Labels
Breaking changes for 3.0 🦤 Discussion 🤔 Needs PR This issue is accepted, sufficiently specified and now needs an implementation pyreverse Related to pyreverse component
Milestone

Comments

@DudeNr33
Copy link
Collaborator

DudeNr33 commented Mar 9, 2023

Visual Compiler Graphs is currently one of the supported output formats for pyreverse.
However this is a very old format (the linked article talks about MS Windows 3.1 😀), and it is really hard to even find tools that can render this format.
The link included in the source code does not contain a download link as promised, and the mentioned debian package cannot be found anymore.

I talked to various colleagues that I thought might have heard about this format, but no one ever did.

Especially because verifying changes to the .vcg testdata is hard and might even scare potential contributors, I propose to deprecate - or even better, as it is seemingly very outdated and probably not used anymore - remove .vcg support entirely.

Maybe we could put the deprecation warning in 2.17 and remove it for 3.0?

@DudeNr33 DudeNr33 added pyreverse Related to pyreverse component Discussion 🤔 labels Mar 9, 2023
@DanielNoord
Copy link
Collaborator

👍 remove!

@Pierre-Sassoulas
Copy link
Member

In 3.0 even.

@DudeNr33
Copy link
Collaborator Author

DudeNr33 commented Mar 9, 2023

Perfect!

I mean, we lose cool features like the fisheye view, but hey I guess that's the price to pay. 😆
image

@DudeNr33 DudeNr33 added Needs PR This issue is accepted, sufficiently specified and now needs an implementation Breaking changes for 3.0 🦤 labels Mar 9, 2023
@Pierre-Sassoulas
Copy link
Member

The 90's were wild, impressive stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes for 3.0 🦤 Discussion 🤔 Needs PR This issue is accepted, sufficiently specified and now needs an implementation pyreverse Related to pyreverse component
Projects
None yet
3 participants