Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.pyi files are not discovered when running on a folder #9097

Closed
DetachHead opened this issue Oct 3, 2023 · 0 comments · Fixed by #9241 or #9461
Closed

.pyi files are not discovered when running on a folder #9097

DetachHead opened this issue Oct 3, 2023 · 0 comments · Fixed by #9241 or #9461
Assignees
@jacobtylerwalls
Labels
Enhancement ✨ Improvement to a component Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Milestone
3.1.0

Comments

@DetachHead
Copy link
Contributor

DetachHead commented Oct 3, 2023 •
edited
Loading

Bug description

# asdf/foo.py
foo = 1

# asdf/bar.pyi
foo = 1

Configuration

No response

Command used

pylint asdf

Pylint output

************* Module foo
asdf\foo.py:1:0: C0104: Disallowed name "foo" (disallowed-name)
asdf\foo.py:1:0: C0104: Disallowed name "foo" (disallowed-name)

Expected behavior

************* Module foo
asdf\foo.py:1:0: C0104: Disallowed name "foo" (disallowed-name)
asdf\foo.py:1:0: C0104: Disallowed name "foo" (disallowed-name)
asdf\bar.pyi:1:0: C0104: Disallowed name "foo" (disallowed-name)
asdf\bar.pyi:1:0: C0104: Disallowed name "foo" (disallowed-name)

Pylint version

pylint 3.0.0a7
astroid 3.0.0
Python 3.11.2 (tags/v3.11.2:878ead1, Feb  7 2023, 16:38:35) [MSC v.1934 64 bit (AMD64)]

OS / Environment

windows 10

Additional dependencies

No response
@DetachHead DetachHead added the Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling label Oct 3, 2023
@DetachHead DetachHead mentioned this issue Oct 5, 2023
Open
@jacobtylerwalls jacobtylerwalls added Needs PR This issue is accepted, sufficiently specified and now needs an implementation and removed Needs triage 📥 Just created, needs acknowledgment, triage, and proper labelling labels Nov 16, 2023
@jacobtylerwalls jacobtylerwalls self-assigned this Nov 16, 2023
@jacobtylerwalls jacobtylerwalls added this to the 3.1.0 milestone Nov 16, 2023
@jacobtylerwalls jacobtylerwalls added the Enhancement ✨ Improvement to a component label Nov 16, 2023
@jacobtylerwalls jacobtylerwalls mentioned this issue Nov 16, 2023
Merged
@jacobtylerwalls jacobtylerwalls mentioned this issue Feb 4, 2024
Closed
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Feb 8, 2024
Closed
@RuRo RuRo mentioned this issue Feb 13, 2024
Open
@Pierre-Sassoulas Pierre-Sassoulas mentioned this issue Feb 25, 2024
Merged
netbsd-srcmastr referenced this issue in NetBSD/pkgsrc Mar 3, 2024
@0-wiz-0
py-pylint: update to 3.1.0.
e20c625 
New Features
------------

- Skip ``consider-using-join`` check for non-empty separators if an ``suggest-join-with-non-empty-separator`` option is set to ``no``.

  Closes #8701 (`#8701 <https://github.com/pylint-dev/pylint/issues/8701>`_)

- Discover ``.pyi`` files when linting.

  These can be ignored with the ``ignore-patterns`` setting.

  Closes #9097 (`#9097 <https://github.com/pylint-dev/pylint/issues/9097>`_)

- Check ``TypeAlias`` and ``TypeVar`` (PEP 695) nodes for ``invalid-name``.

  Refs #9196 (`#9196 <https://github.com/pylint-dev/pylint/issues/9196>`_)

- Support for resolving external toml files named pylintrc.toml and .pylintrc.toml.

  Closes #9228 (`#9228 <https://github.com/pylint-dev/pylint/issues/9228>`_)

- Check for `.clear`, `.discard`, `.pop` and `remove` methods being called on a set while it is being iterated over.

  Closes #9334 (`#9334 <https://github.com/pylint-dev/pylint/issues/9334>`_)



New Checks
----------

- New message `use-yield-from` added to the refactoring checker. This message is emitted when yielding from a loop can be replaced by `yield from`.

  Closes #9229. (`#9229 <https://github.com/pylint-dev/pylint/issues/9229>`_)

- Added a ``deprecated-attribute`` message to check deprecated attributes in the stdlib.

  Closes #8855 (`#8855 <https://github.com/pylint-dev/pylint/issues/8855>`_)


False Positives Fixed
---------------------

- Fixed false positive for ``inherit-non-class`` for generic Protocols.

  Closes #9106 (`#9106 <https://github.com/pylint-dev/pylint/issues/9106>`_)

- Exempt ``TypedDict`` from ``typing_extensions`` from ``too-many-ancestor`` checks.

  Refs #9167 (`#9167 <https://github.com/pylint-dev/pylint/issues/9167>`_)



False Negatives Fixed
---------------------

- Extend broad-exception-raised and broad-exception-caught to except*.

  Closes #8827 (`#8827 <https://github.com/pylint-dev/pylint/issues/8827>`_)

- Fix a false-negative for unnecessary if blocks using a different than expected ordering of arguments.

  Closes #8947. (`#8947 <https://github.com/pylint-dev/pylint/issues/8947>`_)



Other Bug Fixes
---------------

- Improve the message provided for wrong-import-order check.  Instead of the import statement ("import x"), the message now specifies the import that is out of order and which imports should come after it.  As reported in the issue, this is particularly helpful if there are multiple imports on a single line that do not follow the PEP8 convention.

  The message will report imports as follows:
  For "import X", it will report "(standard/third party/first party/local) import X"
  For "import X.Y" and "from X import Y", it will report "(standard/third party/first party/local) import X.Y"
  The import category is specified to provide explanation as to why pylint has issued the message and guidence to the developer on how to fix the problem.

  Closes #8808 (`#8808 <https://github.com/pylint-dev/pylint/issues/8808>`_)



Other Changes
-------------

- Print how many files were checked in verbose mode.

  Closes #8935 (`#8935 <https://github.com/pylint-dev/pylint/issues/8935>`_)

- Fix a crash when an enum class which is also decorated with a ``dataclasses.dataclass`` decorator is defined.

  Closes #9100 (`#9100 <https://github.com/pylint-dev/pylint/issues/9100>`_)
@Hnasar Hnasar mentioned this issue Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Enhancement ✨ Improvement to a component Needs PR This issue is accepted, sufficiently specified and now needs an implementation
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Discover .pyi files jacobtylerwalls/pylint
Release branch 3.1.0 pylint-dev/pylint
2 participants
@jacobtylerwalls @DetachHead