Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dummy variables for 'redeclared-assigned-name' #3384

Merged

Conversation

BennyTheSen
Copy link
Contributor

@BennyTheSen BennyTheSen commented Feb 4, 2020

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Added a check for the 'dummy-variables-rgx' option to '_check_redeclared_assign_name' as suggested in #3341 .
This results in a non failed check if a reassigned variable matches with the regex.

Not sure if this counts as bugfix or feature.

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 89.888% when pulling 164c970 on BennyTheSen:feature/redeclared-assigned-name into aca6d53 on PyCQA:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 89.888% when pulling 164c970 on BennyTheSen:feature/redeclared-assigned-name into aca6d53 on PyCQA:master.

@coveralls
Copy link

coveralls commented Feb 4, 2020

Coverage Status

Coverage increased (+0.002%) to 89.895% when pulling ba7c91e on BennyTheSen:feature/redeclared-assigned-name into ab9e7c3 on PyCQA:master.

Copy link
Contributor

@PCManticore PCManticore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BennyTheSen Thanks for sending this PR over! Overall it looks good but we definitely need some tests as well, can you add a test for this particular change as well?

@BennyTheSen
Copy link
Contributor Author

Hey @PCManticore . I extended the existend testcases with some cases using the option I added. Is this sufficient?

@PCManticore PCManticore merged commit 06fa775 into pylint-dev:master Feb 5, 2020
@PCManticore
Copy link
Contributor

Hey @BennyTheSen Thank you, that looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants