Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix False positive on Enum.__members__.items() #4135

Merged
merged 11 commits into from
Feb 27, 2021
Merged

Fix False positive on Enum.__members__.items() #4135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
40fcb10
Fix False positive on Enum.__members__.items()
ikraduya Feb 23, 2021
646be6d
Fix benchmark test (#4138)
cdce8p Feb 23, 2021
581ad1b
Run ci checks on every release branch
cdce8p Feb 23, 2021
8f39e8f
Retcon the changelog after 2.7.1 release
Pierre-Sassoulas Feb 23, 2021
8cbcf87
Guide the user more in the bug report
Pierre-Sassoulas Feb 22, 2021
fe609b1
Fix false positive on Enum.__members__.{values, keys}
ikraduya Feb 24, 2021
49f8592
Fix False positive on Enum.__members__.items()
ikraduya Feb 23, 2021
2314f04
Fix false positive on Enum.__members__.{values, keys}
ikraduya Feb 24, 2021
4736887
Merge branch 'Issue4123' of https://github.com/ikraduya/pylint into I…
ikraduya Feb 24, 2021
090a068
Add description in ChangeLog
ikraduya Feb 24, 2021
1a4b1f0
Update ChangeLog
Pierre-Sassoulas Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pylint/checkers/typecheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,17 @@ def _emit_no_member(node, owner, owner_name, ignored_mixins=True, ignored_none=T
return False
except astroid.NotFoundError:
return True
if (
owner.parent
and isinstance(owner.parent, astroid.ClassDef)
and owner.parent.name == "EnumMeta"
and owner_name == "__members__"
and node.attrname == "items"
):
# Avoid false positive on Enum.__members__.items()
# See https://github.com/PyCQA/pylint/issues/4123
return False

return True


Expand Down
10 changes: 10 additions & 0 deletions tests/functional/m/member_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,3 +217,13 @@ def __init__(self, flag):
else:
self.attribute = []
self.attribute.append(1)

from enum import Enum
class Animal(Enum):
ANT = 1
BEE = 2
CAT = 3
DOG = 4
# To test false positive no-member on Enum.__members__.items()
for itm in Animal.__members__.items():
print(itm)