-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report import-private-name
for relative imports
#7079
Merged
Pierre-Sassoulas
merged 1 commit into
pylint-dev:main
from
scop:fix/relative-private-imports
Jun 28, 2022
Merged
Don't report import-private-name
for relative imports
#7079
Pierre-Sassoulas
merged 1 commit into
pylint-dev:main
from
scop:fix/relative-private-imports
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2577494235
π - Coveralls |
This comment has been minimized.
This comment has been minimized.
Wow, ^that "Effect of this PR" report is awesome π― |
Yeah credit to @DanielNoord :) It's the first time someone fix SO much false positives at once too. |
Pierre-Sassoulas
added
False Positive π¦
A message is emitted but nothing is wrong with the code
Needs backport
Needs to be cherry-picked on the current patch version by a pylint's maintainer
labels
Jun 28, 2022
Pierre-Sassoulas
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change, big result, that's great π
scop
force-pushed
the
fix/relative-private-imports
branch
from
June 28, 2022 15:48
9dec7fb
to
8e94d7a
Compare
scop
force-pushed
the
fix/relative-private-imports
branch
from
June 28, 2022 15:52
8e94d7a
to
144b1a5
Compare
Pierre-Sassoulas
approved these changes
Jun 28, 2022
Pierre-Sassoulas
added
Backported
and removed
Needs backport
Needs to be cherry-picked on the current patch version by a pylint's maintainer
labels
Jun 29, 2022
Pierre-Sassoulas
pushed a commit
to Pierre-Sassoulas/pylint
that referenced
this pull request
Jun 29, 2022
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #7078