-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap plugin cache to pickle-able values when done #7640
Swap plugin cache to pickle-able values when done #7640
Commits on Oct 17, 2022
-
Swap plugin cache to pickle-able values when done
When the dictionary has served its purpose (making plugin loading pre-and-post init a consistent behaviour), we swap it for bools indicating whether or not a module was loaded. We don't currently use the bools, but it seemed a sensible choice. The main idea is to make the dictionary fully pickle-able, so that when dill pickles the linter for multiprocessing, it doesn't crash horribly.
daogilvie committedOct 17, 2022 Configuration menu - View commit details
-
Copy full SHA for ed4bdeb - Browse repository at this point
Copy the full SHA ed4bdebView commit details -
Fix spelling in comment complaints from pylint
daogilvie committedOct 17, 2022 Configuration menu - View commit details
-
Copy full SHA for d62cb05 - Browse repository at this point
Copy the full SHA d62cb05View commit details -
Correct tense in news fragment 7635.bugfix
Co-authored-by: DaniΓ«l van Noord <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d982854 - Browse repository at this point
Copy the full SHA d982854View commit details -
Add a test for linter pickle-ability
This should cover the case where plugins are loaded and parallel running is enabled.
Configuration menu - View commit details
-
Copy full SHA for 170d923 - Browse repository at this point
Copy the full SHA 170d923View commit details
Commits on Oct 18, 2022
-
Fix test to use specifically pickle-unsafe module
The test also includes an assert to confirm the module picked is actually unsafe, in case it is made safe in the future. Also include docstring edits suggested by reviews.
daogilvie committedOct 18, 2022 Configuration menu - View commit details
-
Copy full SHA for 1c06535 - Browse repository at this point
Copy the full SHA 1c06535View commit details -
Restructure pickle test to for extra plugins
Running in isolation and as part of the full suite cause different default plugins to be loaded, which throw different pickling errors. This will now catch all of them, and still fail the test if all of those modules become pickle safe in future.
daogilvie committedOct 18, 2022 Configuration menu - View commit details
-
Copy full SHA for 695fc14 - Browse repository at this point
Copy the full SHA 695fc14View commit details
Commits on Oct 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e35bd84 - Browse repository at this point
Copy the full SHA e35bd84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13c0cc5 - Browse repository at this point
Copy the full SHA 13c0cc5View commit details -
Shorten my name in the contributor file
daogilvie committedOct 20, 2022 Configuration menu - View commit details
-
Copy full SHA for 93e7923 - Browse repository at this point
Copy the full SHA 93e7923View commit details