Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap plugin cache to pickle-able values when done #7640

Merged
merged 9 commits into from
Oct 20, 2022
Merged

Swap plugin cache to pickle-able values when done #7640

merged 9 commits into from
Oct 20, 2022

Commits on Oct 17, 2022

  1. Swap plugin cache to pickle-able values when done

    When the dictionary has served its purpose (making plugin loading
    pre-and-post init a consistent behaviour), we swap it for bools
    indicating whether or not a module was loaded.
    We don't currently use the bools, but it seemed a sensible choice.
    The main idea is to make the dictionary fully pickle-able, so that when
    dill pickles the linter for multiprocessing, it doesn't crash horribly.
    daogilvie committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ed4bdeb View commit details
    Browse the repository at this point in the history
  2. Fix spelling in comment complaints from pylint

    daogilvie committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d62cb05 View commit details
    Browse the repository at this point in the history
  3. Correct tense in news fragment 7635.bugfix

    Co-authored-by: DaniΓ«l van Noord <[email protected]>
    daogilvie and DanielNoord authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    d982854 View commit details
    Browse the repository at this point in the history
  4. Add a test for linter pickle-ability

    This should cover the case where plugins are loaded and parallel running
    is enabled.
    daogilvie committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    170d923 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Fix test to use specifically pickle-unsafe module

    The test also includes an assert to confirm the module picked is
    actually unsafe, in case it is made safe in the future.
    Also include docstring edits suggested by reviews.
    daogilvie committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    1c06535 View commit details
    Browse the repository at this point in the history
  2. Restructure pickle test to for extra plugins

    Running in isolation and as part of the full suite cause different
    default plugins to be loaded, which throw different pickling errors.
    This will now catch all of them, and still fail the test if all of those
    modules become pickle safe in future.
    daogilvie committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    695fc14 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Address review comments from cdce8p

    Thanks for the review!
    daogilvie committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e35bd84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13c0cc5 View commit details
    Browse the repository at this point in the history
  3. Shorten my name in the contributor file

    daogilvie committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    93e7923 View commit details
    Browse the repository at this point in the history