-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Try
node
#7767
Use Try
node
#7767
Conversation
Pull Request Test Coverage Report for Build 3461295648
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
74f0d21
to
eb5f76b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thanks for all your work guys! I don't find much time lately to work on pylint, unfortunately but it's great to see it's still going strong. Especially thanks to you @jacobtylerwalls! The astroid improvements look awesome and there's even support for Python 3.12 already. Happy to see that my |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ! Wondering about the need for a changelog entry (not to warn about our internals change) but about the mc cabe and disable change in behavior
@@ -39,6 +39,8 @@ async def complex_function(this, function, has, more, arguments, than, | |||
return than | |||
try: | |||
return one | |||
except TypeError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was happening here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests expected too-many-branches
. The try of a try/finally was double-counted before, so here adding an except back corrects the count and keeps the total identical.
@@ -311,7 +311,7 @@ def test_enable_message_block(initialized_linter: PyLinter) -> None: | |||
# meth6 | |||
assert not linter.is_message_enabled("E1101", 57) | |||
assert linter.is_message_enabled("E1101", 61) | |||
assert not linter.is_message_enabled("E1101", 64) | |||
assert linter.is_message_enabled("E1101", 64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change to warn about in changelog ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor, glad it's being merged after so much time/work !
Description
Update pylint to use new
Try
node which replaces the oldTryExcept
andTryFinally
nodes.Refs: pylint-dev/astroid#1867