-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape special symbols and newlines in messages. #9164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9164 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 173 173
Lines 18692 18692
=======================================
Hits 17901 17901
Misses 791 791
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2023
(cherry picked from commit df0800e)
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Oct 18, 2023
(cherry picked from commit df0800e) Co-authored-by: theirix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I skimmed through all the
args
usage in messages and tested a few suspicious strings. Everything looks good and usesas_string()
call. The only thing to fix is amagic-value-comparison
from the referenced ticket.Closes #7874