-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "function never returning" computation #9535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for this as well?
This fixes 2 bugs in the computation: * `Never` is handled in addition to `NoReturn`. * Give priority to the explicit `--never-returning-functions` option. Closes pylint-dev#7565
I'm running out of development cycles for this triviality, so I'm giving up here. The change is correct, but I'm tired of fighting against the obscure CI of this project, spending roughly 10 times more with strange tooling, tests etc. than with the fix itself. If anybody wants to pick this up: Fine. If not: One more detail where pylint is falling behind modern Python features ("Never"). |
I'm sorry you found the CI to be annoying. What part specifically could we improve on? We'd like to make contributing as easy as possible but we're so used to our own tools that sometimes it is hard to see where we are lacking. |
Thank you Daniel, same sentiment here. Please do not hesitate to ask maintainers for advices before becoming too annoyed to contribute @svenpanne :) In this case, we're supporting python interpreter from 3.8 to 3.12 (cython and pypy) so we have tests for each python interpreters (also multiple OSes). Without looking too much into it, it's possible that this typing option doesn't make sense in python < 3.10 and we should just not test it (with a
|
Hey, I could not add commits to this PR but I have applied your suggestion @Pierre-Sassoulas. Let me know if anything else is needed (I'm waiting to see if the CI is green or not) |
Superseded by #9591 |
This fixes 2 bugs in the computation:
Never
is handled in addition toNoReturn
.--never-returning-functions
option.Type of Changes
Description
Closes #7565