Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive for consider-using-dict-items #9594

Merged
merged 8 commits into from
May 4, 2024
Merged

Fix a false positive for consider-using-dict-items #9594

merged 8 commits into from
May 4, 2024

Commits on May 3, 2024

  1. Fix a false positive for consider-using-dict-items when iterating… 

    … ``os.environ`` using the ``os.environ.keys()`` operation and then deleting an item using the key as a lookup.

Closes pylint-dev#9554
    @mbyrnepr2
    mbyrnepr2 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    13accb5 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Update doc/whatsnew/fragments/9554.false_positive 

    Co-authored-by: Pierre Sassoulas <[email protected]>
    @mbyrnepr2 @Pierre-Sassoulas
    mbyrnepr2 and Pierre-Sassoulas authored May 4, 2024
    Configuration menu
    Copy the full SHA
    bf17fd7 View commit details
    Browse the repository at this point in the history

  2. Update tests/functional/c/consider/consider_using_dict_items.py 

    Co-authored-by: Pierre Sassoulas <[email protected]>
    @mbyrnepr2 @Pierre-Sassoulas
    mbyrnepr2 and Pierre-Sassoulas authored May 4, 2024
    Configuration menu
    Copy the full SHA
    9cc8a2a View commit details
    Browse the repository at this point in the history

  3. Update tests/functional/c/consider/consider_using_dict_items.py 

    Co-authored-by: Pierre Sassoulas <[email protected]>
    @mbyrnepr2 @Pierre-Sassoulas
    mbyrnepr2 and Pierre-Sassoulas authored May 4, 2024
    Configuration menu
    Copy the full SHA
    b3d15fd View commit details
    Browse the repository at this point in the history

  4. Regenerate the functional test output after change to the test module.

    @mbyrnepr2
    mbyrnepr2 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    530d1e8 View commit details
    Browse the repository at this point in the history

  5. Remove the unnecessary disable.

    @mbyrnepr2
    mbyrnepr2 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    0bd8a1a View commit details
    Browse the repository at this point in the history

  6. Run black.

    @mbyrnepr2
    mbyrnepr2 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    7b5ddea View commit details
    Browse the repository at this point in the history

  7. Regenerate functional test output again (after running black).

    @mbyrnepr2
    mbyrnepr2 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    1f2a0da View commit details
    Browse the repository at this point in the history