Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional stdlib deprecations (mostly 3.13) #9853

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
✨ New feature

See:
https://docs.python.org/3.13/whatsnew/3.13.html#new-deprecations

@jacobtylerwalls jacobtylerwalls added Skip news 🔇 This change does not require a changelog entry python 3.13 labels Aug 5, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.3.0 milestone Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (de6e6fa) to head (0af34af).
Report is 50 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9853   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18932    18933    +1     
=======================================
+ Hits        18137    18139    +2     
+ Misses        795      794    -1     
Files with missing lines Coverage Δ
pylint/checkers/imports.py 94.86% <ø> (ø)
pylint/checkers/stdlib.py 96.27% <ø> (+0.01%) ⬆️

... and 9 files with indirect coverage changes

This comment has been minimized.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔥 I'll need a PC to be able to review tough, going back between doc and code is hell on mobile. (~= in about a week). There was a discussion in python core about getting this info from a data structure directly, I can't wait :D

@Pierre-Sassoulas
Copy link
Member

This is still on my radar, it's hard to review even on PC though (the release notes translation 💦 making sure that everything is done and that nothing shouldn't be done 💦 💦 ). I'm going to grab a pencil.

Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are now emitted:

  1. unsubscriptable-object:
    Value 'self.hass.data[DOMAIN]' is unsubscriptable
    https://github.com/home-assistant/core/blob/3601c531f400255d10b82529549e564fbe483a54/homeassistant/components/media_source/models.py#L89
  2. unsupported-assignment-operation:
    'self.hass.data[DATA_LAST_WAKE_UP]' does not support item assignment
    https://github.com/home-assistant/core/blob/3601c531f400255d10b82529549e564fbe483a54/homeassistant/components/assist_pipeline/pipeline.py#L770
  3. unsupported-assignment-operation:
    'self.run.hass.data[DATA_LAST_WAKE_UP]' does not support item assignment
    https://github.com/home-assistant/core/blob/3601c531f400255d10b82529549e564fbe483a54/homeassistant/components/assist_pipeline/pipeline.py#L1377
  4. unsupported-assignment-operation:
    'self.hass.data[DOMAIN]' does not support item assignment
    https://github.com/home-assistant/core/blob/3601c531f400255d10b82529549e564fbe483a54/homeassistant/components/system_health/__init__.py#L228

This comment was generated for commit 0af34af

@jacobtylerwalls jacobtylerwalls merged commit 67acc96 into main Sep 18, 2024
44 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/313-deprecations branch September 18, 2024 15:54
@Pierre-Sassoulas
Copy link
Member

Thank you for reviewing Daniel, this got lost in the pile of things I need to do (trying to unclutter now 😅 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python 3.13 Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants