Fix false negative for multiple-statements
on try... else/finally lines
#9917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
I took a look at 5bdc221 and noticed that some inference logic got removed in
format.py
while refactoring to use the updatedTry
node. The purpose of this PR is to reintroduce the inference ofelse
andfinally
line numbers to check for multiple statements onelse/finally
lines in a try statement.This check is a little explicit because of how
else
andfinally
is represented in the AST, without a tree node to represent anelse
orfinally
line. However, it should work for general cases, except for unusual cases like:Closes #9759