Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: pm.sampling.jax functions are not included in PyMC docs #6854

Open
Tracked by #7053
cluhmann opened this issue Aug 11, 2023 · 5 comments
Open
Tracked by #7053

DOC: pm.sampling.jax functions are not included in PyMC docs #6854

cluhmann opened this issue Aug 11, 2023 · 5 comments

Comments

@cluhmann
Copy link
Member

cluhmann commented Aug 11, 2023

Issue with current documentation:

Various functions made available via pm.sampling.jax, including sample_numpyro_nuts() and sample_blackjax_nuts() do not appear in the documentation despite these functions having docstrings. Maybe we didn't include the pm.sampling.jax module is some auto-docing because it was a bit experimental at the time?

@cluhmann cluhmann added the docs label Aug 11, 2023
@OriolAbril
Copy link
Member

They are here: https://www.pymc.io/projects/docs/en/stable/api/samplers.html#samplers. Should they have their own section instead of being listed along other "sampling" functions?

@cluhmann
Copy link
Member Author

I guess the issue is that they don't show up in search results?

@OriolAbril
Copy link
Member

They don't? What was the search string?

@cluhmann
Copy link
Member Author

cluhmann commented Aug 17, 2023

Here is an example. The closest thing that comes back is a link to the entry in the index.

Edit: numpyro too.

@OriolAbril
Copy link
Member

OriolAbril commented Aug 31, 2023

it looks like the search engine works but is quite bad 😓. Not sure how to fix this. It looks like sample_numpyro_nuts is treated as a substring of the pymc.sampling.jax.sample_numpyro_nuts string, and substring search is a bit limited.

First of all, I am not sure if the search functionality is provided by sphinx, the theme or by readthedocs. In addition, as we have multiple builds and libraries, the search defaults to searching over all subprojects (which seems to add some extra challenges).

It would be great if someone could look into how the search function works on the website. I'll be more than happy to answer any question about the website structure and building process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants