Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lib.exe #2

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Add support for lib.exe #2

merged 1 commit into from
Apr 17, 2022

Conversation

Copy link
Collaborator

@ravenexp ravenexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. I suggested using conditional compilation to reduce footprint for non-windows targets.

Also, I've been in the process of adding some basic CI testing (#1), so it probably makes sense to add a new CI job that runs the crate unit tests in the windows-latest environment as well. It has MSVC 17.1 pre-installed, so everything should hopefully work out of the box.

Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@messense messense requested a review from ravenexp April 17, 2022 09:53
Copy link
Collaborator

@ravenexp ravenexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Edit: MinGW dlltool is not found on windows-latest, which leads to partial unit test failures. Maybe these tests can be made conditional on #[cfg(unix)] or you could figure out how to install MinGW binutils via MSYS2 pacman.

@messense
Copy link
Member Author

Since mingw64 is already tested on Linux, I choose to add #[cfg(unix)]s.

@messense messense requested a review from ravenexp April 17, 2022 11:50
@ravenexp
Copy link
Collaborator

Everything seems fine, thank you!

I'll release it as 0.2.1 in a few days, after I figure out how to publish crates from GitHub Actions.

@ravenexp ravenexp merged commit 6e2da70 into PyO3:main Apr 17, 2022
@messense messense deleted the lib.exe branch April 17, 2022 13:03
@messense
Copy link
Member Author

after I figure out how to publish crates from GitHub Actions.

Here is an example: https://github.com/PyO3/maturin/blob/e289772a137a07a6feea3c1c53dd99db6e800830/.github/workflows/release.yml#L8-L33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants