-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for lib.exe
#2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. I suggested using conditional compilation to reduce footprint for non-windows targets.
Also, I've been in the process of adding some basic CI testing (#1), so it probably makes sense to add a new CI job that runs the crate unit tests in the windows-latest
environment as well. It has MSVC 17.1 pre-installed, so everything should hopefully work out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Edit: MinGW dlltool is not found on windows-latest
, which leads to partial unit test failures. Maybe these tests can be made conditional on #[cfg(unix)]
or you could figure out how to install MinGW binutils via MSYS2 pacman
.
Since mingw64 is already tested on Linux, I choose to add |
Everything seems fine, thank you! I'll release it as |
Here is an example: https://github.com/PyO3/maturin/blob/e289772a137a07a6feea3c1c53dd99db6e800830/.github/workflows/release.yml#L8-L33 |
Thanks! Just published |
https://docs.microsoft.com/en-us/cpp/build/reference/building-an-import-library-and-export-file?view=msvc-170