Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate stable_abi.txt updates #6

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Automate stable_abi.txt updates #6

merged 1 commit into from
Apr 19, 2022

Conversation

messense
Copy link
Member

Closes #5

@adamreichold
Copy link
Member

Will this open a PR even if there are no changes to the file?

@messense
Copy link
Member Author

https://github.com/marketplace/actions/create-pull-request#action-behaviour

Will this open a PR even if there are no changes to the file?

What happens if the commit aborts because there are no changes?

If there are no changes (i.e. no diff exists with the checked-out base branch), no pull request will be created and the action exits silently.

@messense
Copy link
Member Author

I'll merge it and trigger it manually to verify it works.

@messense messense merged commit 998f626 into main Apr 19, 2022
@messense messense deleted the cron-update branch April 19, 2022 02:24
@messense
Copy link
Member Author

First working PR: #7

@messense
Copy link
Member Author

Second run with no changes to stable_abi.txt does not create new PR and exits silently: https://github.com/PyO3/python3-dll-a/runs/6071326864?check_suite_focus=true

So it works!

@ravenexp
Copy link
Collaborator

It works great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate stable_abi.txt updates
3 participants