Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are skipped on pre-release Pythons #1137

Closed
nitzmahone opened this issue Jun 13, 2022 · 1 comment · Fixed by #1138
Closed

Tests are skipped on pre-release Pythons #1137

nitzmahone opened this issue Jun 13, 2022 · 1 comment · Fixed by #1138

Comments

@nitzmahone
Copy link
Contributor

Description

On cibuildwheel==2.6.1, when running with CIBW_PRERELEASE_PYTHONS=1, any configured test command is always skipped when targeting a pre-release Python version. A quick glance at the code makes me think it's an unintended consequence of having TestSelector inherit the prerelease exclusion behavior from IdentifierSelector.

Build log

https://github.com/rolpdog/cffi-mirror/runs/6867587654?check_suite_focus=true

CI config

rolpdog/cffi-mirror@b7a0115#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd
@nitzmahone nitzmahone mentioned this issue Jun 13, 2022
Merged
@joerick
Copy link
Contributor

joerick commented Jun 15, 2022

Thanks for submitting this. It does indeed look like a bug.

@henryiii henryiii mentioned this issue Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure tests run on prerelease Pythons nitzmahone/cibuildwheel
2 participants
@joerick @nitzmahone