chore: clean up a little typing #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
joerick
approved these changes
Oct 3, 2022
|
My goodness our tests are flaky at the moment. It's the pip error again. |
|
Haha, yes. :) Currently running into a bug with pylint that it understands |
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
commented
Oct 3, 2022
Comment on lines
116
to
118
| @staticmethod | ||
| # pylint: disable-next=inconsistent-return-statements | ||
| def bitness_archs(platform: PlatformName, bitness: Literal["64", "32"]) -> set[Architecture]: |
There was a problem hiding this comment.
This is a really ugly place to put this lint disable comment. :/
There was a problem hiding this comment.
Should (hopefully) be temporary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on my lectures for this week (which are over static typing), and remembered we can clean this up. It doesn't even need a typing extensions bump; 4.1 is sufficient.