Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PowerShell 7.3 in GHA #1741

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

jborean93
Copy link
Contributor

Fixes compatibility with PowerShell 7.3 on Windows through GitHub Actions when one of the options for cibuildwheel is empty.

I'm not sure how you want to go about this but I believe this should solve the issue with the migration of GHA to PowerShell 7.4 that is happening now.

Fixes: #1740

Fixes compatibility with PowerShell 7.3 on Windows through GitHub
Actions when one of the options for cibuildwheel is empty.
@jborean93 jborean93 changed the title Add support for PowerShell 7.4 in GHA Add support for PowerShell 7.3 in GHA Jan 29, 2024
@jborean93
Copy link
Contributor Author

I've used pythongssapi/python-gssapi#342 to test out these changes.

Both work with the changes in the PR.

Copy link
Contributor

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for a quick fix. Hopefully in a few months everyone will be on 7.3+ and we can simply this to look much more like the bash version, getting rid of the weird double quoting finally.

@jborean93
Copy link
Contributor Author

I would assume you would still want this fix due to self hosted runners that might be running with 7.2. 7.2 EOL is November 8th 2024 https://learn.microsoft.com/en-us/powershell/scripting/install/powershell-support-lifecycle?view=powershell-7.4#powershell-end-of-support-dates

Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick PR. I guess we want to get this out pretty quick if the Windows image update rollout is gonna break everyone.

@joerick joerick merged commit bc55e8b into pypa:main Jan 30, 2024
18 checks passed
@jborean93 jborean93 deleted the pwsh-7.4 branch January 30, 2024 20:17
@jborean93
Copy link
Contributor Author

Thanks for the reviews!

@henryiii
Copy link
Contributor

I'd probably not bother to remove this workaround until 2025 or so. Just nice to think we can eventually remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions Windows: Invalid --only='""' (fixed in 2.16.5)
3 participants