Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set VSCMD_ARG_TGT_ARCH based on targetted architecture #1876

Merged
merged 10 commits into from
Jul 12, 2024
Merged

set VSCMD_ARG_TGT_ARCH based on targetted architecture #1876

merged 10 commits into from
Jul 12, 2024

Commits on Jul 9, 2024

  1. set VSCMD_ARG_TGT_ARCH based on targetted architecture

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    230a869 View commit details
    Browse the repository at this point in the history

  2. only set VSCMD_ARG_TGT_ARCH if not already set

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ceb885b View commit details
    Browse the repository at this point in the history

  3. add unit tests to check setuptools correctly identifies windows arch

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cd9a880 View commit details
    Browse the repository at this point in the history

  4. only run tests on windows

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c1fba36 View commit details
    Browse the repository at this point in the history

  5. arm64 fails on azure pipelines (only)

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cedaf84 View commit details
    Browse the repository at this point in the history

  6. Update windows.py

    @henryiii
    henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a5c8382 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @henryiii
    pre-commit-ci[bot] authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a3e72e5 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Joe Rickerby <[email protected]>
    @henryiii @joerick
    henryiii and joerick committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4d319bf View commit details
    Browse the repository at this point in the history

  9. update test_env_set to validate FatalError is raised on env collision

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9ee0d28 View commit details
    Browse the repository at this point in the history

  10. remove noqa ARG001 (no longer needed)

    @MusicalNinjaDad @henryiii
    MusicalNinjaDad authored and henryiii committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fba21a9 View commit details
    Browse the repository at this point in the history