Skip to content

Commit

Permalink
Updated comment-matching regex to be Jython-compatible (#5959)
Browse files Browse the repository at this point in the history
  • Loading branch information
pradyunsg authored May 30, 2019
2 parents 0cb8f60 + 6599f99 commit 83d813c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions news/3662.trivial
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Work around an issue with Jython's `re` implementation that resulted in a Java StackOverflowError.
2 changes: 1 addition & 1 deletion src/pip/_internal/req/req_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
__all__ = ['parse_requirements']

SCHEME_RE = re.compile(r'^(http|https|file):', re.I)
COMMENT_RE = re.compile(r'(^|\s)+#.*$')
COMMENT_RE = re.compile(r'(^|\s+)#.*$')

# Matches environment variable-style values in '${MY_VARIABLE_1}' with the
# variable name consisting of only uppercase letters, digits or the '_'
Expand Down

0 comments on commit 83d813c

Please sign in to comment.