Merge pull request #10844 from pradyunsg/accept-lowercase-doctype

pypa · Jan 30, 2022 · 9dec8a5 · 9dec8a5
2 parents 6cc96c2 + d028ae5
commit 9dec8a5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/news/10844.bugfix.rst b/news/10844.bugfix.rst
@@ -0,0 +1 @@
+Accept lowercase ``<!doctype html>`` on index pages.
diff --git a/src/pip/_internal/index/collector.py b/src/pip/_internal/index/collector.py
@@ -401,7 +401,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         self.anchors: List[Dict[str, Optional[str]]] = []
 
     def handle_decl(self, decl: str) -> None:
-        if decl != "DOCTYPE html":
+        if decl.lower() != "doctype html":
             self._raise_error()
         self._seen_decl = True
 

diff --git a/tests/data/indexes/yanked/simple/index.html b/tests/data/indexes/yanked/simple/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <body>
     <a href="../../../packages/simple-1.0.tar.gz">simple-1.0.tar.gz</a>
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Accept lowercase ``<!doctype html>`` on index pages.