Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that --ignore-installed is dangerous #6794

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Document that --ignore-installed is dangerous #6794

merged 3 commits into from
Jul 30, 2019

Conversation

native-api
Copy link
Contributor

pfmoore
pfmoore approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know what other @pypa/pip-committers think. Does anyone think the proposed wording is too strong? I'm happy with it, myself.

pradyunsg
pradyunsg approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ambivalent on the wording -- it works for me but I don't really feel strongly either way.

@pradyunsg
Copy link
Member

Merging since... well... it works well enough?

@pradyunsg pradyunsg merged commit dc7f2b9 into pypa:master Jul 30, 2019
@pradyunsg
Copy link
Member

Thanks @native-api for the PR! :D

@native-api native-api deleted the ignore_install_considered_harmful branch July 30, 2019 08:02
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@native-api @pradyunsg @pfmoore