Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pip upgrade notice on for OS package distributions #7459

Closed
mcandre opened this issue Dec 9, 2019 · 3 comments
Closed

Skip pip upgrade notice on for OS package distributions #7459

mcandre opened this issue Dec 9, 2019 · 3 comments
Labels
auto-locked Outdated issues that have been locked by automation project: <downstream> When the cause/effect is related to redistributors state: needs discussion This needs some more discussion type: enhancement Improvements to functionality

Comments

@mcandre
Copy link

mcandre commented Dec 9, 2019

When Python / pip are installed using operating system facing packages, such as RPM, apt, Homebrew, Chocolatey, and so on, then it might be a good idea to skip the pip upgrade notice. When a user actually follows the upgrade advice, they may enter a broken package state.

@triage-new-issues triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Dec 9, 2019
@chrahunt chrahunt added project: <downstream> When the cause/effect is related to redistributors state: needs discussion This needs some more discussion labels Dec 9, 2019
@triage-new-issues triage-new-issues bot removed the S: needs triage Issues/PRs that need to be triaged label Dec 9, 2019
@chrahunt
Copy link
Member

chrahunt commented Dec 9, 2019

Thanks for thinking of this and bringing it up here. No joke, I had this same thought when going through issues recently. :)

IMO this is the responsibility of projects/distributions repackaging pip. I think it would be a lot of work to maintain code in pip to recognize whether it is system-managed for all the different systems, but trivial for maintainers of those downstream projects to carry a one-line patch defaulting --disable-pip-version-warning-check to True here.

@chrahunt chrahunt added the type: enhancement Improvements to functionality label Dec 9, 2019
@pradyunsg
Copy link
Member

Thanks for filing this! I agree and this has been previously discussed in #5346.

@pradyunsg
Copy link
Member

Given that #6468 provides a more general approach for this, I'm gonna go ahead and close this issue. :)

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation project: <downstream> When the cause/effect is related to redistributors state: needs discussion This needs some more discussion type: enhancement Improvements to functionality
Projects
None yet
Development

No branches or pull requests

3 participants