-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for Windows Integrated Authentication/Single Sign-on #8163
Comments
Hi! Thanks for filing an issue @fedorbirjukov! I'm not a Windows user (currently) and definitely not familiar w/ their SSO. Is there some reason you can't use the keyring integration to achieve this? |
Oh yes, I missed the motivational part. Will try to summarize it below. The keyring integration requires each user to
Something else:
With windows integrated authentication support you don't have any of these issues. |
Can keyring not do windows integrated authentication? Could it be updated to add this, if not? My understanding was that the point of keyring integration was to avoid needing pip to support lots of different authentication options, so ideally I'd prefer to go down that route if we could. |
I think I’m not familiar with Windows Integrated Authentication. Is this a way to do it with |
@uranusjr Ah yes, that makes sense. I'm still a little hesitant to have pip accumulate lots of this type of feature. Maybe we should have a more generic approach that lets users "plug in" requests extensions like this, without needing pip code changes? This is of course another aspect of the wider "pip should have a plugin API" discussion, but I think that discussing such things based on a specific use case is more helpful than having a general "pip should do plugins" debate. Basically, I'm in favour of tackling this as a use case for #4475.
Yes, that's what the OP's implementation does. |
I’m going to use #4475 as an aggregated tracking issue for all these similar problems, since it is unlikely pip is going to add support for each authentication methods separately. |
What's the problem this feature will solve?
Support private PyPI indexes with integrated windows authentication.
Describe the solution you'd like
Add an option for integrated windows authentication/single sign-on.
See last commit on this branch for the implementation that I am currently using.
Since pip can read its options from the environment, it can be used in two ways:
Set pip options in the command
Set pip options in the environment
Alternative Solutions
No alternatives yet.
Additional context
This is very similar to
Invoke-WebRequest -UseDefaultCredentials
in PowerShell, which uses the credentials of the current user to send the web request.I didn't open a pull request for this because I want to hear your opinions first.
Related to issue #4475 (pip should support custom authentication handlers for private pypi).
The text was updated successfully, but these errors were encountered: