Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case warning for requirements.txt install #9915

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Special case warning for requirements.txt install #9915

merged 4 commits into from
Jul 12, 2021

Conversation

briantracy
Copy link
Contributor

Added a special warning for users who accidentally do
pip install requirements.txt and forget the -r flag.
Issue #9908

@briantracy
Special case warning for requirements.txt install
8fa1be1 
Added a special warning for users who accidentally do
`pip install requirements.txt` and forget the `-r` flag.
Issue pypa#9908
@briantracy
Special case warning for requirements.txt install
04d113f 
Added entry to news/ directory documenting change.
Issue pypa#9908
uranusjr
uranusjr requested changes Apr 30, 2021
View reviewed changes
news/9915.feature.rst Outdated Show resolved Hide resolved
src/pip/_internal/resolution/resolvelib/factory.py Outdated Show resolved Hide resolved
briantracy and others added 2 commits April 29, 2021 20:15
@briantracy @uranusjr
Update news/9915.feature.rst
0354376 
Co-authored-by: Tzu-ping Chung <[email protected]>
@briantracy
Special case warning for requirements.txt install
39398cb 
Changed log level of special case warning to info
instead of critical.
uranusjr
uranusjr approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to wait until 21.1.1 is release. but otherwise LGTM.

@briantracy
Copy link
Contributor Author

@uranusjr Thanks for the approval, could you run the CI so that everything is set in stone for next release? Thanks.

@briantracy
Copy link
Contributor Author

@uranusjr Looks like 21.1.2 is now out, what is the status on this merge? Thanks again.

@uranusjr uranusjr merged commit 37a2b12 into pypa:main Jul 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briantracy @uranusjr