Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle file: URL equivalency #10186

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Correctly handle file: URL equivalency #10186

merged 2 commits into from
Jul 23, 2021

Conversation

uranusjr
Copy link
Member

Fix #10162.

uranusjr added 2 commits July 23, 2021 15:38
@uranusjr
Add test case for file://localhost/ usages
6db4003
@uranusjr
Correctly handle file://localhost/ and file:///
be89ea5 
According to RFC 8089, an empty host value (i.e. "file:///") should be
taken to be "localhost" (i.e. "file://localhost/"), so we need to
perform some additional normalization to compare such URLs correctly.
@uranusjr uranusjr added this to the 21.2 milestone Jul 23, 2021
@uranusjr uranusjr changed the title Add test case for file://localhost/ usages Correctly handle file: URL equivalency Jul 23, 2021
@uranusjr uranusjr merged commit c5abdda into pypa:main Jul 23, 2021
@uranusjr uranusjr deleted the new-resolver-file-link-localhost branch July 23, 2021 09:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.2
Development

Successfully merging this pull request may close these issues.

Link comparison fails to normalise file://localhost/
2 participants
@uranusjr @pradyunsg