Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send the pip upgrade prompt to stderr #11287

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Send the pip upgrade prompt to stderr #11287

merged 1 commit into from
Jul 22, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Jul 22, 2022

Closes #11282

sbidoul
sbidoul approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, @q0w !
I tested and it correctly sends the message to stderr while preserving the rich colors.

@sbidoul sbidoul added this to the 22.2.1 milestone Jul 22, 2022
@pfmoore pfmoore merged commit 0d4e9eb into pypa:main Jul 22, 2022
@pfmoore
Copy link
Member

pfmoore commented Jul 22, 2022

Thanks for the fix @q0w 🙂

@sbidoul
Copy link
Member

sbidoul commented Jul 22, 2022 •
edited
Loading

Actually, all logging should go to stderr, but that is another story (#6758)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@pfmoore pfmoore pfmoore approved these changes

@sbidoul sbidoul sbidoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.2.1
Development

Successfully merging this pull request may close these issues.

Pip upgrade prompt is not sent to stderr anymore
4 participants
@q0w @pfmoore @sbidoul @pradyunsg