Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Subversion class method definition order #6614

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Fix Subversion class method definition order #6614

merged 2 commits into from
Jun 15, 2019

Conversation

johnthagen
Copy link
Contributor

@johnthagen johnthagen commented Jun 15, 2019 •
edited
Loading

Follow on clean up as described in #6515 (comment)

cc @cjerdonek

@cjerdonek cjerdonek added C: vcs pip's interaction with version control systems like git, svn and bzr skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code labels Jun 15, 2019
cjerdonek
cjerdonek reviewed Jun 15, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one comment. I see now that four methods that are affected and not just two.

src/pip/_internal/vcs/subversion.py Outdated Show resolved Hide resolved
@cjerdonek
Copy link
Member

By the way, I noticed that "info" can be removed from get_remote_call_options()'s docstring. Maybe you can do that in this PR, too.

@johnthagen
Copy link
Contributor Author

@cjerdonek See the latest changes.

@johnthagen
Move switch and update method to group with other instance methods.
ccdfd68 
Remove `svn info` from list of commands that need get_remote_call_args in docstring
@cjerdonek cjerdonek merged commit d25e741 into pypa:master Jun 15, 2019
@johnthagen johnthagen deleted the svn-cleanup branch June 16, 2019 00:20
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjerdonek cjerdonek cjerdonek left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnthagen @cjerdonek