Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defining multiple values for supported options #7918

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Defining multiple values for supported options #7918

merged 1 commit into from
Mar 28, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Mar 28, 2020 •
edited
Loading

Fixes and closes #7803 and closes #7804

Added example of defining multiple values for options which support them like --find-links or --trusted-host

uranusjr
uranusjr requested changes Mar 28, 2020
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of minor fixes on words for consistency with other parts of the documentation, otherwise this is good to go.

docs/html/user_guide.rst Outdated Show resolved Hide resolved
docs/html/user_guide.rst Outdated Show resolved Hide resolved
@deveshks deveshks force-pushed the document-adding-list-of-values-to-options branch from 71c3232 to 77a7340 Compare March 28, 2020 12:23
@deveshks deveshks requested a review from uranusjr March 28, 2020 12:24
@xavfernandez xavfernandez merged commit 326efa5 into pypa:master Mar 28, 2020
@xavfernandez
Copy link
Member

Thanks @deveshks 👍

@xavfernandez xavfernandez mentioned this pull request Mar 28, 2020
Closed
@deveshks deveshks deleted the document-adding-list-of-values-to-options branch March 28, 2020 14:08
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
3 participants
@deveshks @xavfernandez @uranusjr