-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipenv does not give feedback on installing initially failed dependencies. #3586
Comments
The return code tells the success of the installation. PR is welcomed. |
Also, passing If the process completes the packages should be installed. I guess the question is: are you experiencing something different? |
As a user, it just seems a bit 'scary' that the installation failed the first time, so if after that you don't get feedback on a successful retry, you are left wondering whether the retry was successful. However, I do understand the idea that 'pipenv only lets you know when something goes wrong, not when it goes right'. (Even though you get feedback about the creation of the venv Successfully created virtual environment!) I just thought it would simply require a one-line edit in the module that prints 'all dependencies installed successfully' as a reassurance to the user. If things are more complicated than that, you don't need to bother and as far as I'm concerned this can be closed |
@BramVanroy that perspective is very helpful, thank you for taking the time to make that connection -- it's easy to focus on the technical elements but lose focus on the UX which is definitely critical to me at least and which I will always find persuasive, especially where it is inconsistent.
This is a fantastic suggestion, and we may want to consider suppressing the failure notice. |
As long as the final result is that everything installed successfully, I don't think failure notices need to be displayed, indeed. I would leave that to |
So, this has been biting us for some time, but lately the problem has increased significantly and it is seriously impeding our workflow, because packages are silently failing to install. Here's the gist of what's happening:
It's incredibly frustrating that PipEnv is failing to install packages without providing any feedback and without exiting with a non-zero error code. Such a drastic malfunction should be top-priority for fixing. Now, I understand that there's an underlying issue here (something is causing our dependencies to fail to install, and that's on our end), but we should be able to reply on our dependency install process to properly fail and tell us about the problem when it fails. |
Can I work on this? |
Do I just need to suppress the failure notice |
I just spend the last 2 days trying to troubleshoot the flood of errors ("An error occurred while installing") I get when performing a bare sync. I have upgraded to the lastest python, upgraded pip, upgraded pipenv, upgraded all my package versions, generated new Pipfile.lock. After finding this post I realized after running with --verbose that it is eventually able to install them. So, you're telling me these bright red "errors" can be ignored? This seems like a very bad UX decision. I would think that the "errors" should only be displayed after all attempts have failed. Maybe show a warning when the initial installation failed and then an error when all attempts have failed? |
This is still happening |
Hi @techalchemy, Can you please specify the exact requirement? |
Can I work on this issue? |
I'm happy to draft a PR for this. @techalchemy @oz123 |
Feel free. Happy to see interest to work on this issue. |
I am trying out the latest version (from the master branch) to find out if some earlier issues are fixed, but I stumble upon something else.
When installing some dependencies (in my case
numpydoc==0.8.0
andoverrides==1.9
), this fail with the message Will try again. Indeed, pipenv lets me know 'Installing initially failed dependencies...' but does not give any feedback whether it succeeded or failed.As you can see, on the third last line it tells me it will try again, but eventually I don't know whether it succeeded or not.
$ pipenv --support
Pipenv version:
'2018.11.27.dev0'
Pipenv location:
'C:\\Python\\Python37\\lib\\site-packages\\pipenv-2018.11.27.dev0-py3.7.egg\\pipenv'
Python location:
'C:\\Python\\Python37\\python.exe'
Python installations found:
3.7.1
:C:\Python\Python37\python.exe
3.6.8
:C:\Python\Python36\python.exe
PEP 508 Information:
System environment variables:
ACLOCAL_PATH
ALLUSERSPROFILE
ANDROID_SDK_HOME
APPDATA
BAZEL_SH
COMMONPROGRAMFILES
COMPUTERNAME
COMSPEC
CONFIG_SITE
CUDA_PATH
CUDA_PATH_V10_0
COMMONPROGRAMFILES(X86)
COMMONPROGRAMW6432
DISPLAY
DRIVERDATA
EXEPATH
HOME
HOMEDRIVE
HOMEPATH
HOSTNAME
INFOPATH
INTEL_LICENSE_FILE
LANG
LOCALAPPDATA
LOGONSERVER
MANPATH
MINGW_CHOST
MINGW_PACKAGE_PREFIX
MINGW_PREFIX
MSMPI_BIN
MSYSTEM
MSYSTEM_CARCH
MSYSTEM_CHOST
MSYSTEM_PREFIX
NUMBER_OF_PROCESSORS
NVCUDASAMPLES10_0_ROOT
NVCUDASAMPLES_ROOT
OLDPWD
ORIGINAL_PATH
ORIGINAL_TEMP
ORIGINAL_TMP
OS
ONEDRIVE
ONEDRIVECOMMERCIAL
ONEDRIVECONSUMER
PATH
PATHEXT
PKG_CONFIG_PATH
PLINK_PROTOCOL
PROCESSOR_ARCHITECTURE
PROCESSOR_IDENTIFIER
PROCESSOR_LEVEL
PROCESSOR_REVISION
PROGRAMFILES
PS1
PSMODULEPATH
PUBLIC
PWD
PYTHONIOENCODING
PROGRAMDATA
PROGRAMFILES(X86)
PROGRAMW6432
SESSIONNAME
SHELL
SHLVL
SSH_ASKPASS
SYSTEMDRIVE
SYSTEMROOT
TEMP
TERM
TMP
TMPDIR
USERDOMAIN
USERDOMAIN_ROAMINGPROFILE
USERNAME
USERPROFILE
VBOX_MSI_INSTALL_PATH
VS140COMNTOOLS
VS2017INSTALLDIR
WINDIR
_
PIP_DISABLE_PIP_VERSION_CHECK
PYTHONDONTWRITEBYTECODE
PIP_SHIMS_BASE_MODULE
PIP_PYTHON_PATH
PYTHONFINDER_IGNORE_UNSUPPORTED
PipenvÔÇôspecific environment variables:
DebugÔÇôspecific environment variables:
PATH
:C:\Users\Bram\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Users\Bram\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0\bin;C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0\libnvvp;C:\Program Files\Microsoft MPI\Bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\Program Files\Git\cmd;C:\Program Files\nodejs;C:\Perl\c\bin;C:\Perl\perl\site\bin;C:\Perl\perl\bin;C:\Program Files\PuTTY;C:\Android;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program Files\NVIDIA Corporation\NVIDIA NvDLISR;C:\Python\Python37\Scripts;C:\Python\Python37;C:\Python\Python36\Scripts;C:\Python\Python36;C:\Users\Bram\AppData\Local\Microsoft\WindowsApps;C:\Users\Bram\AppData\Local\Programs\Microsoft VS Code\bin;C:\Users\Bram\AppData\Roaming\npm;C:\Users\Bram\AppData\Local\GitHubDesktop\bin;C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\tools\thundersvm\build\bin\Debug;C:\tools\msys64\usr\bin;C:\tools\bazel;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl
SHELL
:C:\Program Files\Git\usr\bin\bash.exe
LANG
:en_GB.UTF-8
PWD
:C:/Python/projects/PyLT3
Contents of
Pipfile
('C:\Python\projects\PyLT3\Pipfile'):Contents of
Pipfile.lock
('C:\Python\projects\PyLT3\Pipfile.lock'):The text was updated successfully, but these errors were encountered: